Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema support mixed Chinese and English #3440

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Schema support mixed Chinese and English #3440

merged 4 commits into from
Dec 13, 2021

Conversation

heroicNeZha
Copy link
Contributor

@heroicNeZha heroicNeZha commented Dec 9, 2021 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Schema support mixed Chinese and English

# Directly support utf-8 / English / Number
CREATE TAG  队伍(名s字ss1 string);

# Using backquote support UTF-8 / English / Number / Full-width Charactor / Blank
CREATE TAG `队   伍；`(`名s字ss1` string);

Which issue(s)/PR(s) this PR relates to?

close #3426

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist：

  • Documentation affected （Please add the label if documentation needs to be modified.)
  • Incompatible （If it is incompatible, please describe it and add corresponding label.）
  • Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes：

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@heroicNeZha heroicNeZha added doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test labels Dec 9, 2021
@heroicNeZha heroicNeZha linked an issue Dec 9, 2021 that may be closed by this pull request
schema supports mixed Chinese and English #3426
Closed
jievince
jievince reviewed Dec 9, 2021
View reviewed changes
src/parser/parser.yy Outdated Show resolved Hide resolved
@heroicNeZha heroicNeZha force-pushed the mixed_chinese_englist branch from 677d92a to 0e56964 Compare December 9, 2021 02:58
@heroicNeZha heroicNeZha force-pushed the mixed_chinese_englist branch 2 times, most recently from e5c943d to 3a05b98 Compare December 9, 2021 10:38
@Sophie-Xie Sophie-Xie requested a review from CPWstatic December 9, 2021 12:29
CPWstatic
CPWstatic previously approved these changes Dec 9, 2021
View reviewed changes
@heroicNeZha heroicNeZha force-pushed the mixed_chinese_englist branch from 3a05b98 to 11d9098 Compare December 10, 2021 04:07
@codecov-commenter
Copy link

Codecov Report

Merging #3440 (11d9098) into master (ab73b4c) will increase coverage by 0.08%.
The diff coverage is 98.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3440      +/-   ##
==========================================
+ Coverage   85.23%   85.31%   +0.08%     
==========================================
  Files        1277     1289      +12     
  Lines      119088   119823     +735     
==========================================
+ Hits       101502   102232     +730     
- Misses      17586    17591       +5
Impacted Files Coverage Δ
src/graph/optimizer/rule/CollapseProjectRule.cpp 98.24% <ø> (ø)
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp 90.54% <ø> (ø)
...ptimizer/rule/OptimizeTagIndexScanByFilterRule.cpp 90.27% <ø> (ø)
...h/optimizer/rule/PushLimitDownGetNeighborsRule.cpp 93.54% <ø> (ø)
...timizer/rule/PushStepLimitDownGetNeighborsRule.cpp 93.75% <ø> (ø)
...imizer/rule/PushStepSampleDownGetNeighborsRule.cpp 93.93% <ø> (ø)
src/graph/util/FTIndexUtils.cpp 4.12% <ø> (ø)
src/graph/validator/FindPathValidator.cpp 84.78% <ø> (ø)
src/graph/validator/MutateValidator.cpp 94.11% <ø> (+0.05%) ⬆️
src/graph/visitor/VidExtractVisitor.cpp 42.95% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42203d...11d9098. Read the comment docs.

@yixinglu yixinglu merged commit 3e8e095 into vesoft-inc:master Dec 13, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince left review comments

@CPWstatic CPWstatic CPWstatic approved these changes

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema supports mixed Chinese and English
5 participants
@heroicNeZha @codecov-commenter @yixinglu @CPWstatic @jievince